コメント制限機能をv0.24.3でも復活させる #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
一旦こちらもマージして、243の環境で検証でしょうか？ |
|
そうですね、それで良いかと思います！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
#319 の対応です。
小手先ではどうにもならなかったので、今回もdecidim-commentsをまるごと差し替える方式で対応しています。
対応方針は以下の通りです:
COMMENTS_LIMIT定数と、configに設定した値も比較して上限を取得するcomments_limitメソッドを追加して、limitが与えられていない場合の上限値はそこで設定するようにするDecidim::Comments::CommentsHelperのcomments_forメソッドとかでコメントを引っ張ってきているようで、リクエストで与えられたlimitパラメータは呼び出し側では考慮されていないようなので、仕方ないからhelper内でparams[:limit]を参照するようにする📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)